Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (ea2f90f) to head (dc7fc65).

❗ Current head dc7fc65 differs from pull request most recent head 492d89a. Consider uploading reports for the commit 492d89a to get more accurate results

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   98.20%   98.23%   +0.02%     
==========================================
  Files           5        5              
  Lines         223      226       +3     
==========================================
+ Hits          219      222       +3     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sorry, accidentally did some wonky stuff with data_generator.py. Fixed this (to the best of my knowledge) and fixed a bug in the transform_x I wrote. I think this should be working

Thanks for the PR @vhu43, I'll be able to spend more time with it later this week. I'm concerned because there is a syntax error on line 245 (missing parenthesis) and my CI didn't pick it up, so I'm looking into that issue. In the meantime, do you want to push a fix for the syntax error and get tests passing? When I ran them locally, a few failed.

Sure thing, I fixed the error specified in it. I am working on some other analysis for my graduate degree, but will be available to fix implementation issues if needed.

I think we need to update the threshold logic.

Do you want to try updating this code block, to be:

                knee = self.x[threshold_index]
                norm_knee = self.x_normalized[threshold_index]

Then, to get tests to pass you'd have to make these changes:

Change this line in test sine to this:

    expected_knees = [4.5, 4.9, 7.7, 8.1]

and change this line in test logistic
to this:

        online=False,